Skip to content

Commit

Permalink
bus/services: Fix bashisms in org.freedesktop.IBus.session.GNOME.service
Browse files Browse the repository at this point in the history
The "[[ ... ]]" is bash's compound command not in POSIX sh. This style
is problematic in Xorg session in environments where sh is not bash,
suach as Debian and Ubuntu.

BUG=#2397
  • Loading branch information
m-shibata committed Apr 20, 2022
1 parent 17648f0 commit f1c456d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bus/services/org.freedesktop.IBus.session.GNOME.service.in
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Conflicts=gnome-session@gnome-login.target
[Service]
Type=dbus
# Only pull --xim in X11 session, it is done via Xwayland-session.d on Wayland
ExecStart=sh -c '@bindir@/ibus-daemon --panel disable $([[ $XDG_SESSION_TYPE == "x11" ]] && echo "--xim")'
ExecStart=sh -c '@bindir@/ibus-daemon --panel disable $([ "$XDG_SESSION_TYPE" = "x11" ] && echo "--xim")'
Restart=on-abnormal
BusName=org.freedesktop.IBus
TimeoutStopSec=5
Expand Down

0 comments on commit f1c456d

Please sign in to comment.