Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Suite Error on 1.5.13 on Ubuntu 14.04 #1868

Closed
xmaysonnave opened this issue Jul 21, 2016 · 2 comments
Closed

Test Suite Error on 1.5.13 on Ubuntu 14.04 #1868

xmaysonnave opened this issue Jul 21, 2016 · 2 comments

Comments

@xmaysonnave
Copy link

xmaysonnave commented Jul 21, 2016 •
edited

Build the 1.5.13 version on an Ubuntu 14.04
Run the test suite with a make -k check command.
Here is the failure report:

ibus 1.5.13: src/tests/test-suite.log

TOTAL: 13
PASS: 12
SKIP: 0
XFAIL: 0
FAIL: 1
XPASS: 0
ERROR: 0

.. contents:: :depth: 2

FAIL: ibus-engine-switch

/ibus/engine-switch/global-engine:
(/home/xavier/Downloads/ibus-1.5.13/src/tests/.libs/lt-ibus-engine-switch:28232): GLib-CRITICAL **: Source ID 4 was not found when attempting to remove it
Trace/breakpoint trap
FAIL ibus-engine-switch (exit status: 133)

Thanks
@fujiwarat
Copy link
Member

I thought this problem was fixed but actually not.
Thanks for your report.

@fujiwarat
Copy link
Member

The suggested patch is here:
ibus-xx-test.txt

@fujiwarat fujiwarat mentioned this issue Jul 25, 2016
Closed
fujiwarat added a commit that referenced this issue Jul 25, 2016
@fujiwarat
tests/ibus-engine-switch: Don't try to remove non-existing GSource
20068d9 
ibus-engine-switch schedules an idle doing an engine switch, and
also schedules a timeout after 1 microsecond which exits the main
loop. Both of these callbacks will return FALSE, which detaches
the associated GSource from the mainloop and destroys it.

As the only way to exit the mainloop is when the timeout callback runs,
we should not try to run g_source_remove(timeout_id) as it will already
be gone, and this causes a warning.

This commit reorders a bit to make the ordering between the idle and
timeout more obvious, and it gets rid of the calls to g_source_remove()
as they are needed.

BUG=#1868

Review URL: https://codereview.appspot.com/103100044
@fujiwarat fujiwarat mentioned this issue May 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fujiwarat @xmaysonnave