bashism in 1.5.22 src/tests/ibus-desktop-testing-runner

[changwoo]

ibus-desktop-testing-runner in 1.5.22 failed in Debian, in which /bin/sh is not Bash but Dash.

/usr/lib/ibus/installed-tests/ibus-desktop-testing-runner: 173: export: -u`/bus: bad variable name

The problem seems to be $UID setting line which has been changed since 1.5.21. Here is a simple test:

changwoo@dev:~/tmp$ cat idtest.sh
#!/bin/sh

: ${UID:='`id -u`'}

echo "UID: $UID"
export DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/$UID/bus
echo $DBUS_SESSION_BUS_ADDRESS
changwoo@dev:~/tmp$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4  7월 19  2019 /bin/sh -> dash
changwoo@dev:~/tmp$ /bin/sh idtest.sh
UID: `id -u`
idtest.sh: 6: export: -u`/bus: bad variable name
changwoo@dev:~/tmp$ /bin/bash idtest.sh
UID: 1000
unix:path=/run/user/1000/bus
changwoo@dev:~/tmp$ 

Removing single quotes seems to work, at least for dash.

diff --git a/src/tests/ibus-desktop-testing-runner.in b/src/tests/ibus-desktop-testing-runner.in
index 0d9a847c..caaf99e5 100755
--- a/src/tests/ibus-desktop-testing-runner.in
+++ b/src/tests/ibus-desktop-testing-runner.in
@@ -31,7 +31,7 @@
 # POSIX sh has no 'echo -e'
 : ${ECHO:='/usr/bin/echo'}
 # POSIX sh has $UID
-: ${UID:='`id -u`'}
+: ${UID:=`id -u`}
 
 
 PROGNAME=`basename $0`

[fujiwarat]

I created a patch above and does it work for you?

[changwoo]

I created a patch above and does it work for you?

Yes it does with /bin/dash

[fujiwarat]

Thank you for the test.