Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove errorneous glib_check_version() in gtk immodule #2200

Closed
changwoo opened this issue Mar 19, 2020 · 2 comments
Closed

Remove errorneous glib_check_version() in gtk immodule #2200

changwoo opened this issue Mar 19, 2020 · 2 comments
Labels
Component-ibus ibus OpSys-Linux Priority-Medium Type-Enhancement
Milestone
1.5.23

Comments

@changwoo
Copy link

In the gtk2/gtk3 immodule, glib_check_version() is being used to make sure that the installed glib is not older than the glib version which ibus is built with.

ibus/client/gtk2/ibusim.c

Line 44 in 1bdcf21

return glib_check_version (GLIB_MAJOR_VERSION,

But I don't see a reason why glib version is checked in runtime. Library compatibility is already being checked more precisely by packaging systems and linkers.

This version check breaks ibus package in Debian testing (http://bugs.debian.org/954207), as ibus was built with glib 2.64.x and the available glib version is 2.62.x which is OK.

Please remove this check.
@fujiwarat
Copy link
Member

OK, I'm fine to remove glib_check_version().
Could you create a pull request to describe the reason in the patch description?

changwoo added a commit to changwoo/ibus that referenced this issue Mar 25, 2020
@changwoo
Remove glib_check_version() in gtk immodule
500a614 
Fixes ibus#2200

In the gtk2/gtk3 immodule, glib_check_version() is being used to make sure
that the installed glib version is not older than the glib version which ibus
is built with.

But there is no reason why glib version is checked in runtime. Library
compatibility is already being checked more precisely by packaging systems and
linkers.

This version check can break the ibus gtk immodule when used with an older but
compatible version of glib, such as glib 2.62.x which is compatible with
2.64.x.
@changwoo changwoo mentioned this issue Mar 25, 2020
Closed
changwoo added a commit to changwoo/ibus that referenced this issue Mar 25, 2020
@changwoo
client/gtk2: Remove glib_check_version() in gtk immodule
9c56fc5 
In the gtk2/gtk3 immodule, glib_check_version() is being used to make sure
that the installed glib version is not older than the glib version which ibus
is built with.

But there is no reason why glib version is checked in runtime. Library
compatibility is already being checked more precisely by packaging systems and
linkers.

This version check can break the ibus gtk immodule when used with an older but
compatible version of glib, such as glib 2.62.x which is compatible with
2.64.x.

BUG=ibus#2200
fujiwarat pushed a commit that referenced this issue Apr 15, 2020
@changwoo @fujiwarat
client/gtk2: Remove glib_check_version() in gtk immodule
5765bfd 
In the gtk2/gtk3 immodule, glib_check_version() is being used to make sure
that the installed glib version is not older than the glib version which ibus
is built with.

But there is no reason why glib version is checked in runtime. Library
compatibility is already being checked more precisely by packaging systems and
linkers.

This version check can break the ibus gtk immodule when used with an older but
compatible version of glib, such as glib 2.62.x which is compatible with
2.64.x.

BUG=#2200
@fujiwarat
Copy link
Member

Thank you for the patch.

@fujiwarat fujiwarat added this to the 1.5.23 milestone Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-ibus ibus OpSys-Linux Priority-Medium Type-Enhancement
Projects
None yet
Milestone
1.5.23
Development

No branches or pull requests
2 participants
@changwoo @fujiwarat