Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing g_free() after gdk_display_map_keyval() #2380

Closed
changwoo opened this issue Feb 7, 2022 · 1 comment
Closed

Missing g_free() after gdk_display_map_keyval() #2380

changwoo opened this issue Feb 7, 2022 · 1 comment
Assignees
@fujiwarat
Labels
gnome gtk4 ibus OpSys-All Priority-Medium Type-Defect
Milestone
1.5.25

Comments

@changwoo
Copy link

changwoo commented Feb 7, 2022

According to the reference for gdk_display_map_keyval(), the returned array of GdkKeymapKey should be freed. But client/gtk?/ibusimcontext.c lack g_free().

ibus/client/gtk2/ibusimcontext.c

Line 1953 in c69b61a

if (gdk_display_map_keyval (display, keyval, &keys, &n_keys)) {

fujiwarat pushed a commit that referenced this issue Feb 18, 2022
@changwoo @fujiwarat
client/gtk2/ibusimcontext: Fix forward key keycode for GTK4
5cfe838 
When a keycode is provided (!= 0) for a forwarded key event, convert it to a
GTK keycode before passing it to gtk_im_context_filter_key().

Also free GdkKeymapKey after gdk_display_map_keyval() is called.

BUG=#2380
BUG=#2382
@fujiwarat fujiwarat self-assigned this Feb 18, 2022
@fujiwarat
Copy link
Member

Thank you for the report.

@fujiwarat fujiwarat added this to the 1.5.25 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fujiwarat fujiwarat

Labels
gnome gtk4 ibus OpSys-All Priority-Medium Type-Defect
Projects
None yet
Milestone
1.5.25
Development

No branches or pull requests
2 participants
@changwoo @fujiwarat