Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version oddity - https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29-rc2.tar.gz should be https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29.tar.gz #2584

Open
rubyFeedback opened this issue Nov 17, 2023 · 2 comments

Comments

@rubyFeedback
Copy link

At https://github.com/ibus/ibus/releases:

Version is titled 1.5.29.

However had, the download is only this:

https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29-rc2.tar.gz

I believe this is a mistake. The URL should logically be:

https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29.tar.gz

Compare to 1.5.28 which is correct:

https://github.com/ibus/ibus/releases/download/1.5.28/ibus-1.5.28.tar.gz

I discovered this because I have scripts to automatically download releases,
and while I can easily work around the above, I much prefer consistency, so
I report issues like this even if they are trivial. I believe the proper solution
should be to make this URL work:

https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29.tar.gz

(For the entry at 1.5.29. If you want to keep the older -rc releases too then
these should be named accordingly.)

Thank you for reading.

@rubyFeedback rubyFeedback changed the title Release version oddity - Release version oddity - https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29-rc2.tar.gz should be https://github.com/ibus/ibus/releases/download/1.5.29/ibus-1.5.29.tar.gz Nov 17, 2023
@fujiwarat
Copy link
Member

fujiwarat commented Nov 17, 2023

Thinking about this and I won't make a 1.5.29 tarball because 1.5.29 and 1.5.29-rc2 are same contents.
If I generate a 1.5.29 tarball, the file stamp will be different from 1.5.29-rc2 tarball so I think just adding the git tag is good.
Since 1.5.29, I just change the tag to the final 1.5.29-rcN.

I will update https://github.com/ibus/ibus/wiki/Release-Planning more exactly later.

Thank you.

@tsutsui
Copy link

tsutsui commented Dec 29, 2023

Thinking about this and I won't make a 1.5.29 tarball because 1.5.29 and 1.5.29-rc2 are same contents.

BTW, "about ibus" in 1.5.29 also says "1.5.29-rc2"
ibus-1 5 29-rc2

IMO "just bump release strings" (i.e. remove "-rcN") for the final release is still reasonable.

On pkgsrc I had to add a tweaks in a pkgsrc Makefile to handle tarball names.
NetBSD/pkgsrc@42584f8#diff-b93fba2f7da4e39ee896c5d1f051d736222186cc92a6d1371b21c26c36b633dbR6-R7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants