Fix restart crash #2148
Closed
Fix restart crash #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not close inotify desciptors when restarting the server. This
may lead to crashes in glib.
Fixes crash in libglib/libgio with GLib-GIO-ERROR : inotify read(): Bad file descriptor
See also src/tests/ibus-bus.c: start_exit_async():
/* When `./runtest ibus-bus` runs, ibus-daemon sometimes failed to
* restart because closing a file descriptor was failed in
* bus/server.c:_restart_server() with a following error:
* "inotify read(): Bad file descriptor"
Test plan:
Run
$ ibus restart
several times. Without the patch ibus-daemon will crash occasionally.
fujiwarat
reviewed
Oct 31, 2019
fujiwarat
pushed a commit
that referenced
this pull request
Nov 1, 2019
Do not close inotify desciptors when restarting the server. This
may lead to crashes in glib.
Fixes crash in libglib/libgio with
GLib-GIO-ERROR : inotify read(): Bad file descriptor
See also src/tests/ibus-bus.c: start_exit_async():
/* When `./runtest ibus-bus` runs, ibus-daemon sometimes failed to
* restart because closing a file descriptor was failed in
* bus/server.c:_restart_server() with a following error:
* "inotify read(): Bad file descriptor"
Test plan:
Run
$ ibus restart
several times. Without the patch ibus-daemon will crash occasionally.
BUG=#2148
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close inotify desciptors when restarting the server. This
may lead to crashes in glib.
Fixes crash in libglib/libgio with GLib-GIO-ERROR : inotify read(): Bad file descriptor
See also src/tests/ibus-bus.c: start_exit_async():
/* When
./runtest ibus-busruns, ibus-daemon sometimes failed to* restart because closing a file descriptor was failed in
* bus/server.c:_restart_server() with a following error:
* "inotify read(): Bad file descriptor"
Test plan:
Run
$ ibus restart
several times. Without the patch ibus-daemon will crash occasionally.