Handle small final sigma in ibus_keyval_convert_case #2176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiwarat
pushed a commit
that referenced
this pull request
Jan 24, 2020
lowercase: GREEK SMALL LETTER FINAL SIGMA (U+03C2) uppercase: GREEK CAPITAL LETTER SIGMA (U+03A3) This mapping was correct in UCSConvertCase, but the "legacy" mapping must also be correct for Caps Lock to work with the final sigma key. https://gitlab.freedesktop.org/xorg/lib/libx11/commit/7f46a38139 BUG=#2176
|
Thank you for the patch. The IBus file was converted from the GTK one. |
|
Patch sent: https://gitlab.gnome.org/GNOME/gtk/merge_requests/1351 Do you know if any other library also copied the bad logic? |
|
Thank you. I don't know about other libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the same bug was recently committed to libx11: https://gitlab.freedesktop.org/xorg/lib/libx11/commit/7f46a38139f66fda734f3a6c445b84ea89c8f310