Build the Emoji dictionaries in parallel #2209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building Emoji dictionaries src/dicts/emoji-*.dict in sequence, a pattern rule is specified for them. The make -jN option builds the dictionaries in parallel. The GNU make extensions like pattern rule and patsubst function are used for it. But src/Makefile.am has had other GNU make extensions for a while, so using more extensions should not make portability worse.
|
This change speeds up the build time from ~60s to ~40s for me. |
fujiwarat
pushed a commit
that referenced
this pull request
Apr 23, 2020
Instead of building Emoji dictionaries src/dicts/emoji-*.dict in sequence, a pattern rule is specified for them. The make -jN option builds the dictionaries in parallel. The GNU make extensions like pattern rule and patsubst function are used for it. But src/Makefile.am has had other GNU make extensions for a while, so using more extensions should not make portability worse. BUG=#2209
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building Emoji dictionaries src/dicts/emoji-*.dict in sequence, a
pattern rule is specified for them. The make -jN option builds the
dictionaries in parallel.
The GNU make extensions like pattern rule and patsubst function are used for
it. But src/Makefile.am has had other GNU make extensions for a while, so
using more extensions should not make portability worse.