src, client/x11: Add systemd unit file #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiwarat
requested changes
Jan 26, 2022
There was a problem hiding this comment.
Thank you for the patch.
Please put "BUG=#2377" at the end of the git description.
I think this request would be a little late for Fedora 36 Change and it would be safe to target the integration to IBus 1.5.27 & Fedora 37 as this is a system wide change.
garnacho
added a commit
to garnacho/ibus
that referenced
this pull request
Feb 9, 2022
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
f162eaf
to
c137aad
Compare
garnacho
added a commit
to garnacho/ibus
that referenced
this pull request
Feb 9, 2022
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
c137aad
to
49c2d7d
Compare
garnacho
added a commit
to garnacho/ibus
that referenced
this pull request
Feb 9, 2022
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
49c2d7d
to
149d64c
Compare
garnacho
added a commit
to garnacho/ibus
that referenced
this pull request
Feb 9, 2022
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
149d64c
to
053842e
Compare
garnacho
added a commit
to garnacho/ibus
that referenced
this pull request
Feb 9, 2022
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
053842e
to
4008e9e
Compare
This so far depends on GNOME targets, and is thus just usable there. Other DEs wishing to use systemd and ibus will need to add the necessary dependencies where applicable. There are 2 scenarios here: - On X11 sessions, ibus-daemon will be launched with --xim parameter, so ibus-x11 is started with it. - On Wayland sessions, ibus-daemon will be started without XIM support, ibus-x11 will be launched and tear down together with all other session X11 services while Xwayland is running. For the second part of the second situation, additionally install a script at /etc/xdg/Xwayland-session.d, which takes care of X11 service initialization together with the Xwayland instance. BUG=ibus#2377
garnacho
force-pushed
the
systemd-user-service
branch
from
4008e9e
to
a076b38
Compare
|
the first one is separating ibus-daemon and ibus-x11 startup logic, GNOME Shell on Wayland has capabilities to start/stop Xwayland dynamically on presence of X11 clients, ibus-x11 should follow that And the second reason is https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2235, we are going to raise the file descriptor limit in GNOME Shell/Xwayland, but wouldn't want to have it propagated to other processes |
|
FTR, this is the service running locally on my jhbuild setup on a GNOME Wayland session: |
gnomesysadmins
pushed a commit
to GNOME/gnome-shell
that referenced
this pull request
Feb 10, 2022
IBus is moving to being a systemd managed service in GNOME sessions (see ibus/ibus#2377). Since there will be a transition period, and we still have to support non-systemd sessions, check for this existence at runtime.
gnomesysadmins
pushed a commit
to GNOME/gnome-shell
that referenced
this pull request
Feb 10, 2022
IBus is moving to being a systemd managed service in GNOME sessions (see ibus/ibus#2377). Since there will be a transition period, and we still have to support non-systemd sessions, check for this existence at runtime.
|
The related merge request in GNOME Shell is https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2171 |
|
Thank you very much for your patch. |
gnomesysadmins
pushed a commit
to GNOME/gnome-shell
that referenced
this pull request
Feb 11, 2022
IBus is moving to being a systemd managed service in GNOME sessions (see ibus/ibus#2377). Since there will be a transition period, and we still have to support non-systemd sessions, check for this existence at runtime.
gnomesysadmins
pushed a commit
to GNOME/gnome-shell
that referenced
this pull request
Feb 11, 2022
IBus is moving to being a systemd managed service in GNOME sessions (see ibus/ibus#2377). Since there will be a transition period, and we still have to support non-systemd sessions, check for this existence at runtime.
gnomesysadmins
pushed a commit
to GNOME/gnome-shell
that referenced
this pull request
Feb 11, 2022
IBus is moving to being a systemd managed service in GNOME sessions (see ibus/ibus#2377). Since there will be a transition period, and we still have to support non-systemd sessions, check for this existence at runtime. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2171>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This so far depends on GNOME targets, and is thus just usable there.
Other DEs wishing to use systemd and ibus will need to add the
necessary dependencies where applicable.
There are 2 scenarios here:
so ibus-x11 is started with it.
ibus-x11 will be launched and tear down together with all other
session X11 services while Xwayland is running.
For the second part of the second situation, additionally install
a script at /etc/xdg/Xwayland-session.d, which takes care of X11
service initialization together with the Xwayland instance.