Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpp templates #476

Merged
merged 27 commits into from
Feb 14, 2024
Merged

Conversation

Victoremepunto
Copy link
Contributor

This PR aims to:

  • deprecate app-inteface set of templates
  • Add new set of updated templates (mpp) to be compliant to OCP > 4.14
    • Updates to use Deployment over DeploymentConfig
    • Updates CronJob specs
  • Small fixes and tweaks

Copy link
Collaborator

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small requests else LGTM

ocp-templates/README.md Outdated Show resolved Hide resolved
ocp-templates/README.md Outdated Show resolved Hide resolved
ocp-templates/mpp/backend.yaml Outdated Show resolved Hide resolved
ocp-templates/mpp/backend.yaml Outdated Show resolved Hide resolved
ocp-templates/mpp/frontend.yaml Outdated Show resolved Hide resolved
ocp-templates/mpp/frontend.yaml Show resolved Hide resolved
ocp-templates/mpp/tenant-namespace.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we went through templates on a meeting and made it work correctly. Thank you, Victor!

@LightOfHeaven1994
Copy link
Collaborator

Failure is not related to this PR, tested with dummy PR https://github.com/ibutsu/ibutsu-server/actions/runs/7901012519/job/21563774045?pr=477 , we are good to merge it

@LightOfHeaven1994 LightOfHeaven1994 merged commit 3afdd69 into ibutsu:master Feb 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants