Add resolution to victory core package #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightOfHeaven1994
force-pushed
the
add-resolution-to-victory-core
branch
from
57d1b27
to
9bf8c01
Compare
LightOfHeaven1994
changed the title
LightOfHeaven1994
force-pushed
the
add-resolution-to-victory-core
branch
from
259e1c9
to
bf4dbf1
Compare
LightOfHeaven1994
force-pushed
the
add-resolution-to-victory-core
branch
from
bf4dbf1
to
efb0c71
Compare
Victoremepunto
approved these changes
Feb 16, 2024
mshriver
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves react-chart dependency issue. For more info see patternfly/patternfly-react#10064
Note that PR has both
resolutions(for yarn) andoverrides(for npm). We might need to take a look later how to deal with it and use only one package manager because our tests use yarn and I see yarn is mentioned in the doc but npm is used in Dockerfile to build FE