This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Cache hammer #154
Comments
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
Add 'icekit-events' to ICEKit's setup.py file, which probably isn't the right way to go about doing this but is following the current pattern so we if it's wrong we can fix all of these reqs at the same time. See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
The publishing templates did inline lookups of `get_absolute_url()` on objects to get preview URLs, but this failed for objects which are not URL routable (such as Events in at least some situations). The `get_absolute_url()` lookups are now done in the admin instead, with exception handling to avoid errors for unroutable objects. These errors likely only showed in development mode, but made admin pages unusable in this case. See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
Avoid doing `Placeholder.objects.parent()` lookups on items without placeholder relationships because this does not fail gracefully and just return no results for items with no placeholder relationships, and instead raises a ProgrammingError and aborts the current DB transaction. See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
This is an awful hack. Hopefully we can find a better way. See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
- rename `ListingPage` methods to improve clarity: `get_items` => `get_items_to_list`, `get_visible_items` => `get_items_to_route` - refactor `ListingPage` method handling for item methods so they always get the current HttpRequest passed in as an argument, which can be necessary to customise items to list or route - make result of `get_items_to_list` method available in listing page template context as `items_to_list` instead of calling method directly - update concrete `EventListingPage` to use new ICEKit Events class `AbstractEventListingForDatePage` which now implements the date- filtering behaviour previously done by `AbstractEventListingPage` - update tests and documentation corresponding to changes above. See ICEKit ticket #154 in Assembla
mrmachine
pushed a commit
that referenced
this issue
Apr 30, 2017
The new `SlugMixin` abstract model class adds a `slug` field to models, but more importantly also checks somewhat intelligently that the slug is unique when the item is saved, or when published if the item is also publishable. As part of this change applied a counter-intuitive, and possibly wrong- headed, fix to ensure the `publishing_prepare_published_copy` method that can be implemented by subclasses of `PublishingModel` actually gets called by treating it as an ancestor method. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
- add detail view for Occurrence in addition to Event - view hierarchy for Events > Event > Occurrence - add `visible()` and `published()` filters to Occurrence manager. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
- add `human_dates` & `human_times` fields, and methods to retrieve and display date/time range descriptions using the human versions when available - add `special_instructions` text field - add `attendance_url` URL field - render all new fields in basic Event detail view for manual testing. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
We no longer use MPTT tree structures so there is no need to continue using PolymorphicTreeForeignKey instead of standard ForeignKey. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
- add `EventPage` model - add child admin for `EventPage` based on ICEKit's `TitleSlugAdmin` - clean up cruft from event admin forms - fix plugin registrations for event models to make polymorphic admin features work properly. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
Add `AbstractEventListingPage` to list event occurrences on the current day, or on a date given with a YYYY-mm-dd format `date` GET parameter. NOTE: This relies on a hack in ICEKit's `ListingPage` to pass through the current request as `_plugin_request` class attribute. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
We need to run tests against the ICEKit feature branch which contains WIP changes corresponding to this branch's changes. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
- use new `get_items_to_list` and `get_items_to_route` methods instead of prior `_plugin_request` class attribute hack - move date-filtering behaviour to separate class `AbstractEventListingForDatePage` and leave `AbstractEventListingPage` as a more generic base class that does only minimal published/visible filtering. See ICEKit ticket #154 in Assembla
cogat
pushed a commit
that referenced
this issue
Jun 5, 2017
By using the SlugMixin from ICEKit as a base for EventPage we get slug uniqueness checks on save and publish for free. See ICEKit ticket #154 in Assembla
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: