Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fluent Pages version 1.1 fails unit tests #194

Closed
jmurty opened this issue Feb 19, 2017 · 3 comments
Closed

Fluent Pages version 1.1 fails unit tests #194

jmurty opened this issue Feb 19, 2017 · 3 comments

Comments

@jmurty
Copy link
Contributor

jmurty commented Feb 19, 2017

The recent 1.1 release of django-fluent-pages causes ICEkit's unit tests, and probably the project in general, to fail with the error:

  File "/usr/local/lib/python2.7/dist-packages/fluent_pages/adminui/pageadmin.py", line 135, in _select_template_name
    template_name = native_str(template_name)  # consistent value for lazy() function.
NameError: global name 'native_str' is not defined
@jmurty
Copy link
Contributor Author

jmurty commented Feb 19, 2017

Raised issue against fluent-pages: django-fluent/django-fluent-pages#125

@jmurty
Copy link
Contributor Author

jmurty commented Feb 19, 2017

I have submitted a pull request against the upstream django-fluent-pages project with a simple import fix for this issue: django-fluent/django-fluent-pages#126

jmurty added a commit that referenced this issue Feb 19, 2017
@jmurty
Avoid using django-fluent-pages versions >= 1.1 pending upstream fix,…
b6f5fe7 
… re #194
@cogat cogat added the ready label Feb 22, 2017
jmurty added a commit that referenced this issue Feb 26, 2017
@jmurty
Avoid using django-fluent-pages versions 1.1 with import bug, re #194
56d86ff 
Permit use of versions of django-fluent-pages after 1.1, including
1.1.1 which fixes the import bug for `native_str`
@jmurty
Copy link
Contributor Author

jmurty commented Feb 26, 2017

The django-fluent-pages issue is fixed in version 1.1.1

@jmurty jmurty closed this as completed Feb 26, 2017
@jmurty jmurty removed the ready label Feb 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cogat @jmurty