Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename methods in ArchiveDataFrame and rename as_pandas behavior columns #236

Merged
merged 7 commits into from
Jul 24, 2022
Merged

Rename methods in ArchiveDataFrame and rename as_pandas behavior columns #236

merged 7 commits into from
Jul 24, 2022

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Jul 23, 2022 •
edited
Loading

Description

Renamed the fields to match the new naming conventions.

Also switched the as_pandas() columns to be measure instead of behavior

TODO

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka requested a review from itsdawei July 24, 2022 10:15
itsdawei
itsdawei approved these changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@itsdawei itsdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ribs/archives/_archive_base.py Show resolved Hide resolved
ribs/archives/_archive_data_frame.py Show resolved Hide resolved
@btjanaka btjanaka merged commit a7417a8 into master Jul 24, 2022
@btjanaka btjanaka deleted the archive-dataframe-rename branch July 24, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdawei itsdawei itsdawei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btjanaka @itsdawei