Prevent Optimizer from taking in non-unique emitter instances #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users were previously able to do something like:
However, this is incorrect because
emitters
now contains 5 of the same instance ofGaussianEmitter
, when it should really contain 5 unique instances, which one would get if they instead did:This PR makes sure
Optimizer
cannot take in anemitters
list where any of the members have the sameid()
.Changelog Description
Fixed a bug where Optimizer is able to take in non-unique emitter instances
TODO
Questions
Status
CONTRIBUTING.md.
yapf
pytest
(tox
is run in CI/CD)pylint