Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct namespaces #130

Merged
merged 4 commits into from
Dec 28, 2018
Merged

Correct namespaces #130

merged 4 commits into from
Dec 28, 2018

Conversation

icaOBU
Copy link
Contributor

@icaOBU icaOBU commented Aug 8, 2018

Please check if the PR fulfills these requirements

  • I made sure that my code builds
  • I merged the master into this branch before pushing
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?** (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

#120

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications

use correct namespace

Other information

closes #120

@Meerownymous Meerownymous merged commit f417c94 into master Dec 28, 2018
@Meerownymous Meerownymous deleted the i120-correct-namespaces branch December 28, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meerownymous Meerownymous Awaiting requested review from Meerownymous

@koeeenig koeeenig Awaiting requested review from koeeenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Namespaces
2 participants
@icaOBU @Meerownymous