fix: hmr fail (#189)

* fix: hmr fail * chore: comment
ice-lab · May 7, 2022 · 89f44fa · 89f44fa
1 parent 1e9b585
commit 89f44fa
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/webpack-config/src/index.ts b/packages/webpack-config/src/index.ts
@@ -44,13 +44,19 @@ function getEntry(rootDir: string) {
     // use generated file in template directory
     entryFile = path.join(rootDir, '.ice/entry.client.ts');
   }
+  const dataLoaderFile = path.join(rootDir, '.ice/data-loader.ts');
   return {
-    loader: [path.join(rootDir, '.ice/data-loader.ts')],
     runtime: ['react', 'react-dom', '@ice/runtime'],
     main: {
       import: [entryFile],
       dependOn: 'runtime',
     },
+    // Should set `dependOn` property to avoid hmr fail.
+    // ref: https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/88#issuecomment-627558799
+    loader: {
+      import: [dataLoaderFile],
+      dependOn: 'runtime',
+    },
   };
 }