Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Fix: hmr fail #189

Merged
merged 3 commits into from May 7, 2022
Merged

Fix: hmr fail #189

merged 3 commits into from May 7, 2022

Conversation

luhc228
Copy link
Member

@luhc228 luhc228 commented May 5, 2022

目前会有这个 warning,导致 hmr 失效了:
image

Ref: pmmmwh/react-refresh-webpack-plugin#88 (comment)

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ice-next ✅ Ready (Inspect) Visit Preview May 7, 2022 at 5:13AM (UTC)

runtime: ['react', 'react-dom', '@ice/runtime'],
main: {
import: [entryFile],
dependOn: 'runtime',
},
loader: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

调整顺序就可以解决吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是要加 dependOn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以加个注释,贴下 issue 地址?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chenjun1011
Copy link
Contributor

CI 没过

@luhc228
Copy link
Member Author

luhc228 commented May 6, 2022

CI 没过

强依赖这个 PR #186

@luhc228 luhc228 merged commit 89f44fa into release-next May 7, 2022
@luhc228 luhc228 deleted the fix/hmr-fail branch May 7, 2022 05:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants