Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated test coverage #11

Closed
SteveFortune opened this issue Mar 10, 2014 · 5 comments
Closed

Automated test coverage #11

SteveFortune opened this issue Mar 10, 2014 · 5 comments
Milestone
2.0.0

Comments

@SteveFortune
Copy link
Member

We need some sort of automated coverage so that we can detect regressions caused by external PRs easily.
@SteveFortune
Copy link
Member Author

Need to determine how we are going to do automated test coverage. Maybe we could use a framework like KIF to run scenario tests on the Test App ?

We could also test the delegate logic using traditional unit tests and mocking the pan gesture recogniser.

@SteveFortune SteveFortune changed the title Test coverage Automated test coverage Apr 5, 2014
@SteveFortune
Copy link
Member Author

Can confirm that KIF supports Drag and Drop gestures, not sure how effective this will be. trying it out now.

@SteveFortune
Copy link
Member Author

See branch improvement-11-automated-test-coverage for progress. I am starting to implemented some integration tests for the TestApp.

SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Setup cocoa pods environment and added KIF to the podfile
a357bf8
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Moved controllers into individual folders to make code easier to …
52ba00a 
…browse
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Added empty kif ui actor category that will provide methods for m…
efeabc7 
…avigating between example cases
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Added accessibillity tables to tab buttons in test app's test cases
528ef41
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Implemented untested actor category - moved differet example case…
c007ae1 
… navigation methods into 1 method that accepts the example case number and chooses the case's controller's tab button accessibillity label for from a config arry
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Setup empty Example Case 1 test
7c804e6
SteveFortune added a commit that referenced this issue Apr 5, 2014
@SteveFortune
#11 Began implementing first test
e941e17
SteveFortune added a commit that referenced this issue May 12, 2014
@SteveFortune
#11 Continued impleementing KIF actor
2e9a7c9
SteveFortune added a commit that referenced this issue Jun 13, 2014
@SteveFortune
#11 Finished writing the initial actor helper methods for dragging ce…
63b5dea 
…lls between containers - untested
SteveFortune added a commit that referenced this issue Jun 13, 2014
@SteveFortune
#11 Implemented inital version of pointForIndexPath:inCollectionView
2038d83
@SteveFortune SteveFortune mentioned this issue Sep 13, 2014
Closed
@SteveFortune
Copy link
Member Author

UPDATE branch improvement-11-automated-test-coverage no longer represents the progress of the issue. I have decided to refactor the codebase for #28 to make it more unit test-able instead of covering the framework indirectly via functional test cases for the Example app. This branch is still in the repo incase we want to reference it in the future.

SteveFortune added a commit that referenced this issue Sep 14, 2014
@SteveFortune
#28 #11 Added test to verify that the coordinator adds itself as the …
aa74d31 
…target to the pan gesture recogniser
SteveFortune added a commit that referenced this issue Sep 14, 2014
@SteveFortune
#28 #11 Added more tests for more compatible coordinator ctor and con…
02d260d 
…tinued implementing the new handling logic
SteveFortune added a commit that referenced this issue Sep 14, 2014
@SteveFortune
#28 #11 Wrote unit tests covering the coordinator's dealloc method
a5013cf
@SteveFortune SteveFortune added this to the 2.0.0 milestone Sep 18, 2014
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Stubbed out some failing tests for the other drag starting be…
1bbe4cc 
…hviours
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Wrote passing unit test for collections being completely undr…
0b6883e 
…aggable if they don't have a drag data source
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Wrote passing test for items that the drag data source specif…
35c8b85 
…y as undraggable
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Wrote unit test covering the order of intersecting collections
1a2a577
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Refactored the new start dragging tests to reduce duplication
8903d4a
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Wrote test case for dragging the covers pan gestures initiate…
afdbaa2 
…d outside of any of the arena's collections
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Fixed spelling error in one of the gesture coordinator test c…
51c4719 
…ases
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Started stubbing out the remaining 'drop' test cases for the …
4894b16 
…coordinator
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Fixed spellling error in a log call and removed unnecessary i…
770e1a3 
…mport statement from the gesture coordinator spec
SteveFortune added a commit that referenced this issue Sep 19, 2014
@SteveFortune
#28 #11 Restructured describe blocks slightly so that we can reuse th…
8a251a4 
…e before / after setup
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Figured out that stubbing causes a bad access on 64 bit achitectu…
9ed23f9 
…re because of the assignment of the given array literal.

I'd assumed when calling andReturn, the value passed was retained / copied / managed by the framework but it seems that it isn't reliable held in memory. There is no bad access for example, if I declare the array as a variable like so:

    NSArray* recognizers = @[panGestureRecognizer]
    OCMStub([superview gestureRecognizers]).andReturn(recognizers);

because its autoreleased at the end of the block. For now I've opted just to add gesture recognizers via the defined interface in UIView - seems much simpler
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Removed unneccessary stubb in dtor tests
63547fc
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Began working on refactoring the gesture recognizer tests to be l…
e5252ba 
…ess interdependant

There are multiple nested describe blocks, each with beforeEach blocks setting up an configuring additional mock objects. Its now at the point where these tests are no longer clear and hard to maintain. Refactoring
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Started moving some of the more 'global' dependencies in the gest…
75d6c69 
…ure tests to the local tests
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Continued refactoring gesture coordinator tests to be more readab…
5e50ab1 
…le and less dependent of implicit beforEach setup
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#24 #11 Recognised flaw in design, wrote out some dev notes and decid…
a10fe76 
…ed how to change the design going forward
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Started removing redudant tests. We don't need to test what happe…
f7508a9 
…ns if the dragDataSource is nil because the language defines this behaviour for us (returns NO for BOOl methods). Its redundant to test this
SteveFortune added a commit that referenced this issue Nov 15, 2014
@SteveFortune
#11 Started moving out of the heavily-nested describe block strucutur…
bd09dd3 
…e for the gesture coordinator
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed failing dtor test
20c98e4
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Migrated describe block for different gesture recognizer stop states
9d45736
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Added fixture for implementation of the I3Collection
1aacf9b 
According the OCMock docs, protocol mocks work in the same way as class mocks and therefore have the same limitations when it comes to mocking the same protcol multiple times at once. We've worked around that my partially mocking an instance of a class that implements that protocol. I'm not 100% sure whether partially mocking 2 instances of the same class as once has the same limitations (the docs seems a bit ambiguous).

Also removed unnecessary property in the I3TableView
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Uncomments drop tests now pass
b29f430
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Ensured that the collection fixture implements that correct metho…
c571a37 
…ds and refactored rearrange tests to pass. Note that now, the collection for the 'stopping a valid drop' tests is set up with a draggingItemView
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Migrated half of the exchange drop tests
b67530e
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Finished migrating exchange tests - going to backward test them n…
e2df039 
…ow to see if they break
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Passed exchange tests after a bit of backwards testing
9fa7095
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Finished migrating the dragging and stopping invalid drag tests t…
5ea6e6b 
…o their own un-nested describe blocks
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Moved all the heavily redundant test setup code to a top-level de…
11efaf8 
…scribe block again.

This time we've ensured that only mocked dependencies that are absolutely required across all of the drag / drop tests are
set up in the top level describe block. Before, there were all sorts of dependencies that were stubbed, restubbed, overwritten
and dependent on the class implementation. Now we have cleaner subsets of drag / drop tests
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed rearrange example case - now rearrange edge cases that case…
4aba5f2 
…d crash before have been dealt with
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Coordinator now ignores drag that start in an invalid location in…
8abed11 
… the collection
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Refactored gesture coordinator a bit to reduce duplication and fi…
3939acd 
…xed a regression
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Backwards tested some more of the gesture tests. Discovered and f…
c6bb829 
…ixed some redundant tests
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed 'duplicate symbol' linker error by ensuring that fixture im…
591debf 
…plementations are delcared in .m files instead of all in the .h file. Moved all drag data source fixtures into 1 pair of .h / .m files
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed existing tests for basic drag rendered
7695d66
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed some issues with calling beNil expectation without parentha…
eeeb9f3 
…ses and implemented tests for the renderer to ensure that on rearrange, the exchanging clone view clones the exchange view immediately
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Wrote a failing test for deletion animation in renderer
c10c15b
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Wrote implementation for failing deletion test in basic renderer.…
0552988 
… Now to build some working examples as functional / acceptance tests
SteveFortune added a commit that referenced this issue Nov 16, 2014
@SteveFortune
#11 Fixed issue with shrink animation rendering and played around wit…
64cc5b5 
…h the example case. Also see comments of #28 for a recently discovered limitation
@SteveFortune
Copy link
Member Author

Closing this issue now. All new unit tests for the first iteration of BetweenKit pass. All further production code should be covered with tests. At the moment I'm trying to force myself to adopt TDD so BetweenKit classes should have unit tests. We also need some functional examples (maybe next phase?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@SteveFortune