Fix mapped Operation always returning Outcome::None
#1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
approved these changes
Nov 13, 2022
hecrj
changed the title
Operation always returning Outcome::None
hecrj
force-pushed
the
op_bug_fix_map
branch
from
5892761
to
cbb3475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535.
This fixes the
scrollableissue and the basicfocusissue from the reproduction in the linked issue.However,
focus_previousandfocus_nextremain broken.I suspect that this is due to missing
finishimplementations in both Map and MapRef.After staring at it for a while, I was unable to divine what that method is even supposed to do in this situation, so I'll leave that to someone more knowledgeable.