Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loading already-decoded image pixels #211

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Add support for loading already-decoded image pixels #211

merged 2 commits into from
Mar 1, 2020

Conversation

mrkgnao
Copy link
Contributor

@mrkgnao mrkgnao commented Feb 29, 2020

This solves a use-case I have (an app with an image gallery) where I decode images asynchronously using Commands.

hecrj
hecrj requested changes Feb 29, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This should satisfy a couple of use cases described in #76. Thank you 🚀

We just need to address a small documentation detail and I think we can merge this.

native/src/widget/image.rs Show resolved Hide resolved
@mrkgnao mrkgnao requested a review from hecrj March 1, 2020 12:46
hecrj
hecrj approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks 🥂

@hecrj hecrj merged commit 0d4b6ad into iced-rs:master Mar 1, 2020
@hecrj hecrj added the feature New feature or request label Mar 7, 2020
@hecrj hecrj added this to the 0.1.0 milestone Mar 7, 2020
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrkgnao @hecrj