Skip to content

Commit

Permalink
Disable parsing advancements to fix 1.12.2 Forge SevTech crash (#148) (
Browse files Browse the repository at this point in the history
…#149)

Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
  • Loading branch information
iceiix committed May 14, 2019
1 parent 599227a commit 8d4d606
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/protocol/packet.rs
Expand Up @@ -1706,10 +1706,14 @@ state_packets!(
field pitch: i8 =,
}
packet Advancements {
field data: Vec<u8> =,
/* TODO: fix parsing modded advancements 1.12.2 (e.g. SevTech Ages)
* see https://github.com/iceiix/stevenarella/issues/148
field reset_clear: bool =,
field mapping: LenPrefixed<VarInt, packet::Advancement> =,
field identifiers: LenPrefixed<VarInt, String> =,
field progress: LenPrefixed<VarInt, packet::AdvancementProgress> =,
*/
}
/// EntityProperties updates the properties for an entity.
packet EntityProperties {
Expand Down

0 comments on commit 8d4d606

Please sign in to comment.