Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parsing advancements to fix 1.12.2 Forge SevTech crash (#148) #149

Merged
merged 3 commits into from May 14, 2019

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented May 12, 2019

#148 1.12.2 Forge: SevTech Ages advancements crashes StringError("stream did not contain valid UTF-8")

@iceiix
Copy link
Owner Author

iceiix commented May 12, 2019

With this workaround able to connect to:

SevTech_Ages_Server_3.1.1 (1.12.2, top 3rd on curseforge)

Screen Shot 2019-05-12 at 3 40 17 PM

@iceiix iceiix merged commit 8d4d606 into master May 14, 2019
@iceiix iceiix deleted the advancements branch May 14, 2019 00:13
iceiix added a commit that referenced this pull request Feb 1, 2020
…#149)

Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
iceiix added a commit that referenced this pull request Feb 1, 2020
…#149)

Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
iceiix added a commit that referenced this pull request Feb 1, 2020
…#149)

Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
iceiix added a commit that referenced this pull request Feb 2, 2020
…#149)

Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant