feat: support temporal partition function #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
approved these changes
Aug 28, 2023
| const DAY_PER_SECOND: f64 = 0.0000115741; | ||
| const HOUR_PER_SECOND: f64 = 1_f64 / 3600.0; | ||
|
|
||
| pub struct Year {} |
There was a problem hiding this comment.
Suggested change
| pub struct Year {} | |
| pub struct Year; |
| } | ||
| } | ||
|
|
||
| pub struct Month {} |
There was a problem hiding this comment.
Suggested change
| pub struct Month {} | |
| pub struct Month; |
|
|
||
| /// 1970-01-01 is base date in iceberg. | ||
| /// 719163 is the number of days from 0000-01-01 to 1970-01-01 | ||
| const BASE_DAY_FROM_CE: i32 = 719163; |
There was a problem hiding this comment.
Suggested change
| const BASE_DAY_FROM_CE: i32 = 719163; | |
| const EPOCH_DAYS_FROM_CE : i32 = 719163; |
| } | ||
| } | ||
|
|
||
| pub struct Hour {} |
There was a problem hiding this comment.
Suggested change
| pub struct Hour {} | |
| pub struct Hour; |
|
The ci can be fixed after #164 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.