chore: Upgrade arrow to 46 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 28, 2023
| @@ -14,15 +14,15 @@ members = [ | |||
| anyhow = "1" | |||
| async-trait = "0.1" | |||
| apache-avro = { version = "0.15", features = ["derive"] } | |||
| arrow = { version = ">=40, <47" } | |||
| arrow = { version = "46" } | |||
There was a problem hiding this comment.
We must use 46 here? This could affect our users with other versions.
There was a problem hiding this comment.
Yes, only 46 contains this fix. BTW, is it really a good choice to use range for arrow? IIUC, arrow doesn't guarantee portability cross major versions.
There was a problem hiding this comment.
The correctness of the arrow API is guaranteed by arrow maintainer and endusers, and Icelake is just to ensure that it can compile in this case. Maybe we can use >=46 instead?
There was a problem hiding this comment.
Agree, I will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug in split offsets.
Close #160