keyboardType, validator, label, searchFn, mutipleSelection + format + version + description #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 things to the README.md file: - Values of the `DropdownMenuItem` objects must be strings or implement the `toString()` method. - Clear button. - Assert unique value can be avoided.
Label and error returned by function as Widget:
```
validator: (value){return(value==null?Row(
children: <Widget>[
Icon(Icons.error,color: Colors.red,size: 14,),
SizedBox(width: 5,),
Text("Mandatory",style: TextStyle(color: Colors.red,fontSize: 13),),
],
):null);},
label: (value){return(Row(
children: <Widget>[
Icon(Icons.info,color: Colors.blueAccent,size: 14,),
SizedBox(width: 5,),
Text("Oil producer",style: TextStyle(color: Colors.blueAccent,fontSize: 13),),
],
));},
```
Or as strings:
```
validator: (value){return(value==null?"Mandatory":null);},
label: (value){return("Oil producer");},
```
Possibility to set the keyboard type for searches as follows:
```
keyboardType: TextInputType.number,
```
Improved package description as suggested here: https://pub.dev/packages/searchable_dropdown#-analysis-tab- Increased version from 1.1.0 to 1.1.1
Label and error returned by function as Widget:
```
validator: (value){return(value==null?Row(
children: <Widget>[
Icon(Icons.error,color: Colors.red,size: 14,),
SizedBox(width: 5,),
Text("Mandatory",style: TextStyle(color: Colors.red,fontSize: 13),),
],
):null);},
label: (value){return(Row(
children: <Widget>[
Icon(Icons.info,color: Colors.blueAccent,size: 14,),
SizedBox(width: 5,),
Text("Oil producer",style: TextStyle(color: Colors.blueAccent,fontSize: 13),),
],
));},
```
Or as strings:
```
validator: (value){return(value==null?"Mandatory":null);},
label: (value){return("Oil producer");},
```
Possibility to set the keyboard type for searches as follows:
```
keyboardType: TextInputType.number,
```
Ran:
```
flutter format lib/searchable_dropdown.dart
```
As suggested here:
https://pub.dev/packages/searchable_dropdown#-analysis-tab-
Closed
Added searchFn to README.md to let the user know how to expand the search to keywords separated by a space for example.
New `searchFn` lets the developer define the search function through which the list items are filtered. For example, the string typed by the user can be considered as keywords separated by spaces:
```dart
searchFn: (String keyword, List<DropdownMenuItem<MyData>> items) {
List<int> ret = List<int>();
if (keyword != null && items != null) {
keyword.split(" ").forEach((k) {
int i = 0;
items.forEach((item) {
if (keyword.isEmpty || (k.isNotEmpty &&
(item.value.toString().toLowerCase().contains(k.toLowerCase())))) {
ret.add(i);
}
i++;
});
});
}
if(keyword.isEmpty){
ret = Iterable<int>.generate(items.length).toList();
}
return (ret);
},
```
Here is an example of result:
lcuis
changed the title
Added multiple selection to README mentioning when a parameter has impact.
added multiple selection to pubspec.yaml
### Multiple selection Multiple selection is available through the `multipleSelection` parameter: ```dart multipleSelection: true, ```  This disables `onChanged` callback function. See below. There is a way to customize the display of the selected and unselected items through the `displayItemWhenMultiple` parameter function: ```dart displayItemWhenMultiple: (item,selected) { return (Row(children: [ selected ? Icon(Icons.check, color: Colors.green,) : Icon( Icons.check_box_outline_blank, color: Colors.grey,), SizedBox(width: 7), item ])); }, ```  The done button is displayed only when in multiple selection mode. It can be customized either by setting the String parameter `doneText` or by setting the function parameter `doneButtonFn`: ```dart doneText: "OK", ```  Or: ```dart doneButtonFn: (newContext){return FlatButton( onPressed: () { Navigator.pop(newContext); }, child: Text("I'm through"));}, ```  The multiple items set by default can be set through the parameter `selectedItems` as follows: ```dart List<int> selectedItems = [1,3]; ... selectedItems: selectedItems, ``` Where the int values are the indexes of the selected items in the list of items.  Once the selection is done, the `selectedItems` list above is updated or the values can be retrieved through the `onChangedMultiple` function parameter: ```dart onChangedMultiple: (List<int> selectedIndexes){ selectedIndexes.forEach((item){ print("selected index: $item"); }); }, ``` The indexes of the selected items are sent to this callback function. Note that in the multiple selection case, the `onChanged` callback function is not called as the parameter type is not a list. The `validator` function can also be used in the multiple selection case: ```dart validator: (List<int>selectedIndexes){return(selectedIndexes==null||selectedIndexes.length==0?"Mandatory":null);}, ``` The `selectedValueWidgetFn` function can be used in the mutiple selection case the same way it is used in the single selection case: ```dart selectedValueWidgetFn: (value) => Padding( padding: EdgeInsets.fromLTRB(20, 20, 20, 20), child:Text( value.toString(), style: TextStyle(color:Colors.green), ) ), ``` The clear button works the same way in multiple and single cases.
|
Hello @icemanbsi , |
lcuis
changed the title
* demo app with a gallery as tabs or as a single page (change through a switch) * automated testing * continuous integration (CI) * continuous deployment (CD) * license is MIT * split constructors between single and multiple selection * comments on the constructors * selection can be done in a menu, not just a dialog box * solution to allow flexibility to provide a String, a Widget or a Function that returns either one of String or Widget for several components of the Widget * documentation * keyboard doesn't overlap dialog
|
Hello @icemanbsi , I fell I changed things a bit too much for a PR to make sense now. I hope you don't mind I closed it? Cheers. |
|
Hi @lcuis , |
|
Hello @icemanbsi , Thank you very much for the merge and the contributor proposal! This PR was against my master branch which changed significantly since the PR proposal. It contained many more changes than those listed in the description as this is a different plugin:
This has several consequences for the users:
This also has consequences for your repository:
I will try to correct the consequences for the users so that they are not affected and I will probably remove the automated testing, the CI and the CD. Please let me know if you have a different point of view. |
|
yes, I'm very aware of it. since I haven't published any update on flutter pub, I think it should be ok. |
|
Ok, thanks, I am working on the next PR to correct things for your plugin publication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label and error returned by function as Widget:
Or as strings:
Possibility to set the keyboard type for searches as follows:
New
searchFnlets the developer define the search function through which the list items are filtered. For example, the string typed by the user can be considered as keywords separated by spaces:Here is an example of result:
Multiple selection
Multiple selection is available through the
multipleSelectionparameter:This disables
onChangedcallback function. See below.There is a way to customize the display of the selected and unselected items through the
displayItemWhenMultipleparameter function:The done button is displayed only when in multiple selection mode. It can be customized either by setting the String parameter
doneTextor by setting the function parameterdoneButtonFn:Or:
The multiple items set by default can be set through the parameter
selectedItemsas follows:Where the int values are the indexes of the selected items in the list of items.
Once the selection is done, the
selectedItemslist above is updated or the values can be retrieved through theonChangedMultiplefunction parameter:The indexes of the selected items are sent to this callback function. Note that in the multiple selection case, the
onChangedcallback function is not called as the parameter type is not a list.The
validatorfunction can also be used in the multiple selection case:The
selectedValueWidgetFnfunction can be used in the mutiple selection case the same way it is used in the single selection case:The clear button works the same way in multiple and single cases.
Ran:
As suggested here:
https://pub.dev/packages/searchable_dropdown#-analysis-tab-
Improved package description as suggested here:
https://pub.dev/packages/searchable_dropdown#-analysis-tab-
Increased version from 1.1.0 to 1.1.1
Added to the README.md file:
DropdownMenuItemobjects must be strings or implement thetoString()method.