Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorResource should be platform-dependend #154

Closed
Alex009 opened this issue Jan 19, 2021 · 1 comment · Fixed by #370 or #439
Closed

ColorResource should be platform-dependend #154

Alex009 opened this issue Jan 19, 2021 · 1 comment · Fixed by #370 or #439
Assignees
Labels
enhancement New feature or request

Comments

@Alex009
Copy link
Member

Alex009 commented Jan 19, 2021

now ColorResource is just sealed class with color constants. but we should use on each platform resources of platform. so we generate colors.xml on android, and should have some actual ColorResource(R.color.mycolor) on android. now we got:

actual object colors : ResourceContainer<ColorResource> {
  actual val valueColor: ColorResource.Single = Single(color = Color(0xB02743FF))

that not use platform resources at all...

@Alex009 Alex009 added the enhancement New feature or request label Jan 19, 2021
@Alex009 Alex009 self-assigned this Mar 11, 2023
Alex009 added a commit that referenced this issue Mar 11, 2023
old implementation moved to ColorDesc
Alex009 added a commit that referenced this issue Mar 11, 2023
update versions to update compose-jb
Alex009 added a commit that referenced this issue Mar 11, 2023
Alex009 added a commit that referenced this issue Mar 12, 2023
Alex009 added a commit that referenced this issue Mar 13, 2023
Alex009 added a commit that referenced this issue Mar 13, 2023
Alex009 added a commit that referenced this issue Mar 23, 2023
Alex009 added a commit that referenced this issue Mar 23, 2023
Alex009 added a commit that referenced this issue Mar 23, 2023
@Alex009
Copy link
Member Author

Alex009 commented Mar 24, 2023

will be released in 0.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
1 participant