Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to show error of generation if apple image generator not found valid scales #225

Closed
krottv opened this issue Jul 29, 2021 · 7 comments · Fixed by #320
Closed

Need to show error of generation if apple image generator not found valid scales #225

krottv opened this issue Jul 29, 2021 · 7 comments · Fixed by #320
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@krottv
Copy link
Contributor

krottv commented Jul 29, 2021

moko-resources version - 0.15.1

The issue appeared after I added 2 images under shared/src/commonMain/resources/MR/images

image

Android build works find and images are displayed. Ios build fails with the following:

Execution failed for task ':shared:generateMRiosMain'.
> java.io.FileNotFoundException: some-app/shared/build/generated/moko/iosMain/res/Assets.xcassets/notif_large_icon_free_weekly_templates.imageset/Contents.json (No such file or directory)
@krottv
Copy link
Contributor Author

krottv commented Jul 30, 2021

Fixed if I change image size to @1x.png. But in some cases it is not what is needed

@Alex009
Copy link
Member

Alex009 commented Aug 3, 2021

@Alex009 Alex009 changed the title iosMain/res/Assets.xcassets/notif_large_icon_free_weekly_templates.imageset/Contents.json (No such file or directory) Need to show error of generation if apple image generator not found valid scales Aug 3, 2021
@Alex009
Copy link
Member

Alex009 commented Aug 3, 2021

also we should add error reporting for this case

@Alex009 Alex009 added the enhancement New feature or request label Aug 3, 2021
@krottv
Copy link
Contributor Author

krottv commented Aug 3, 2021

@Alex009
I get it. But what to do if I want to provide x4 for android? Since android supports it. Does it make sence, what do you think?

@Alex009
Copy link
Member

Alex009 commented Aug 3, 2021

Yes you can use 4x for Android, but for iOS also needed 3x

@Alex009 Alex009 added this to the 0.18.0 milestone Aug 31, 2021
@Alex009 Alex009 modified the milestones: 0.18.0, 0.19.0 Jan 14, 2022
@y9san9
Copy link
Collaborator

y9san9 commented Mar 18, 2022

Снимок экрана 2022-03-18 в 22 26 34

@Alex009 Alex009 linked a pull request Mar 21, 2022 that will close this issue
Alex009 added a commit that referenced this issue Mar 21, 2022
…alidator

#225: Added apple generator image scale validator
@Alex009
Copy link
Member

Alex009 commented Mar 21, 2022

will be available in 0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants