Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the export necessary to work on iOS in the readme #61

Closed
dalewking opened this issue Apr 30, 2020 · 5 comments · Fixed by #70
Closed

Document the export necessary to work on iOS in the readme #61

dalewking opened this issue Apr 30, 2020 · 5 comments · Fixed by #70
Assignees
@Alex009
Labels
documentation Improvements or additions to documentation
Milestone
0.10.0

Comments

@dalewking
Copy link

In Issue #53 we learn that there is an extra export statement that is necessary to get this to work on iOS. After losing an entire day trying to figure out why this was not working on iOS, I think it should definitely be documented in the README
@Alex009
Copy link
Member

Alex009 commented Apr 30, 2020

hi!
I'm sorry that you had to spend time looking for a resolution of problem.
We already document in in README - https://github.com/icerockdev/moko-resources#faq
As i see it not help you, maybe you suggest where it should be documented?

@dalewking
Copy link
Author

At least mention it in the Installation section with a reference to the FAQ section. Most people are going to be like us and read the installation section and think that is all there is.

@dalewking
Copy link
Author

I have applied the suggestion in the FAQ but it made no difference, I still only get the localization keys

@dalewking
Copy link
Author

dalewking commented May 1, 2020 •
edited

I did figure it out and got it working

@Alex009 Alex009 added the documentation Improvements or additions to documentation label May 1, 2020
@Alex009 Alex009 self-assigned this May 1, 2020
@Alex009 Alex009 added this to the 0.10.0 milestone May 1, 2020
Alex009 added a commit that referenced this issue May 4, 2020
@Alex009
#61 remove export usage (not required now)
2b69dd1
Alex009 added a commit that referenced this issue May 4, 2020
@Alex009
Merge branch 'master' into #61-export-docs
8b27c82
Alex009 added a commit that referenced this issue May 4, 2020
@Alex009
#61 remove old faq
80cd094
@Alex009
Copy link
Member

Alex009 commented May 4, 2020

start from 0.10.0 export not required.
it was changed by #64 and #65 so we just remove requirement and will not add new info to docs

@Alex009 Alex009 linked a pull request May 4, 2020 that will close this issue
#61 export docs #70
Merged
Alex009 added a commit that referenced this issue May 4, 2020
@Alex009
Merge pull request #70 from icerockdev/#61-export-docs
fbaf28f 
#61 export docs
@Alex009 Alex009 closed this as completed May 4, 2020
@Alex009 Alex009 mentioned this issue May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex009 Alex009

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

#61 export docs icerockdev/moko-resources
2 participants
@dalewking @Alex009