Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.24.0-beta-03 includes removed strings and fails to build #697

Closed
Syer10 opened this issue May 6, 2024 · 3 comments · Fixed by #705
Closed

0.24.0-beta-03 includes removed strings and fails to build #697

Syer10 opened this issue May 6, 2024 · 3 comments · Fixed by #705
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Syer10
Copy link
Contributor

Syer10 commented May 6, 2024

Our translation software makes it difficult to remove translated strings, so we only remove them from the base strings.xml and leave them in the translation files.
But with Moko 0.24.0 beta this seems to cause an error, it adds these removed strings to the MR.strings object, causing builds to fail with this error

e: file:///J:/project/libs/strings/build/generated/kotlin/generateMRandroidMain/com/example/localization/MR.kt:6248:77 Unresolved reference: add_example

Here is the generated code

    public actual val add_example: StringResource = StringResource(R.string.add_example)

And it shows an error on R.string.add_example since it does not exist in the base strings.xml.

@Alex009
Copy link
Member

Alex009 commented May 7, 2024

Hi. Create sample please, where we can reproduce issue

@Syer10
Copy link
Contributor Author

Syer10 commented May 10, 2024

Alex009 added a commit that referenced this issue May 15, 2024
@Alex009 Alex009 linked a pull request May 15, 2024 that will close this issue
@Alex009 Alex009 added this to the 0.24.0 milestone May 15, 2024
@Alex009 Alex009 added the bug Something isn't working label May 15, 2024
Alex009 added a commit that referenced this issue May 15, 2024
@Alex009
Copy link
Member

Alex009 commented May 15, 2024

fixed in 0.24.0-beta-4

@Alex009 Alex009 closed this as completed May 15, 2024
@Alex009 Alex009 self-assigned this May 15, 2024
@Alex009 Alex009 mentioned this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants