Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dependency #718

Closed
zt64 opened this issue May 21, 2024 · 1 comment · Fixed by #719
Closed

Remove unnecessary dependency #718

zt64 opened this issue May 21, 2024 · 1 comment · Fixed by #719
Assignees
@ExNDY
Milestone
0.24.0

Comments

@zt64
Copy link

zt64 commented May 21, 2024

Hi, a problem I've noticed is that moko resources brings in material 2 dependency which is really annoying especially when my project is set to use material 3. I've narrowed it down to this one specific dependency which should be removed. I tested locally and all tests passed

moko-resources/resources-compose/build.gradle.kts

Line 55 in 6ed5168

api(compose.desktop.common)

@zt64 zt64 changed the title Uncessary dependency Unnecessary dependency May 21, 2024
@zt64 zt64 changed the title Unnecessary dependency Remove unnecessary dependency May 21, 2024
@Alex009 Alex009 added this to the 0.24.0 milestone May 22, 2024
ExNDY added a commit that referenced this issue May 22, 2024
@ExNDY
#718 remove useless dependency
df2401c
ExNDY added a commit that referenced this issue May 22, 2024
@ExNDY
#718 fix usage of named sourceSet
c5a767b
@ExNDY ExNDY linked a pull request May 22, 2024 that will close this issue
#718 remove compose dependency #719
Merged
Alex009 added a commit that referenced this issue May 22, 2024
@Alex009
Merge pull request #719 from icerockdev/#718-remove-compose-dependency
8f7f9e4 
#718 remove compose dependency
@Alex009
Copy link
Member

Alex009 commented May 22, 2024

will be released in 0.24.0-beta-5

@Alex009 Alex009 closed this as completed May 22, 2024
@Alex009 Alex009 mentioned this issue Jun 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ExNDY ExNDY

Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

#718 remove compose dependency icerockdev/moko-resources
3 participants
@Alex009 @ExNDY @zt64