FileResource implementation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Tetraquark
requested changes
May 4, 2020
resources/src/androidMain/kotlin/dev/icerock/moko/resources/FileResource.kt
Outdated
Show resolved
Hide resolved
gradle-plugin/src/main/kotlin/dev/icerock/gradle/generator/android/AndroidFilesGenerator.kt
Show resolved
Hide resolved
gradle-plugin/src/main/kotlin/dev/icerock/gradle/generator/ios/IosFilesGenerator.kt
Show resolved
Hide resolved
# Conflicts: # gradle-plugin/src/main/kotlin/dev/icerock/gradle/generator/PluralsGenerator.kt # gradle-plugin/src/main/kotlin/dev/icerock/gradle/generator/StringsGenerator.kt
Tetraquark
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filesdirectory inMRfor filesfilesdirectory of bundleOS differences
if we use same filename in different modules - on android will be used one of this files (from parent module), on iOS will be used different files.
if we have:
mpp-library/src/commonMain/resources/MR/files/test.txtwithfirstcontendmpp-library/nested/src/commonMain/resources/MR/files/test.txtwithsecondcontenton android if we read
mpplib.MR.files.testwe gotfirstand formpplib.nested.MR.files.testtoo will befirstbut on iOS will be as expected:
mpplib.MR.files.test=first,mpplib.nested.MR.files.test=secondhow it solve i don't know now