Add Support for Compact Enums #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Dec 12, 2023
src/validators/enums.rs
Outdated
| }) | ||
| .set_span(enum_def.span()) | ||
| .add_note( | ||
| "compact enums cannot also have underlying types\ntry removing either the 'compact' modifier, or the underlying type", |
There was a problem hiding this comment.
I think we should try to avoid using newlines in these notes.
There was a problem hiding this comment.
Okay, I'll change them all to other punctuation.
What's the problem with newlines though?
The console output will already have newlines from snippets, and the json output is all string-escaped.
ReeceHumphreys
approved these changes
Dec 12, 2023
src/diagnostics/errors.rs
Outdated
Comment on lines
379
to
381
| CompactTypeCannotContainTaggedFields, | ||
| format!("tagged fields are not supported in compact {kind}s\nconsider removing the tag, or making the {kind} non-compact"), | ||
| kind |
There was a problem hiding this comment.
I agree with @externl on the new lines in the error descriptions. Do we do this anywhere else?
There was a problem hiding this comment.
There's a few scattered around notes and error messages.
Just whenever something seemed more readable on two lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #681 by adding support for compact enums.
Compact enums work just like compact structs: we don't encode
TagEndMarker, and tags cannot be used within the enum.A compact enum cannot have an underlying type (since they're already 'compact') nor can it be unchecked (since we already don't encode
TagEndMarkerthen).