Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed references to noproj variable due to capabilities.xml updates #147

Closed
wants to merge 1 commit into from

Conversation

asteiker
Copy link
Collaborator

This is a fix per issue #145

I had some issues updating my fork, so I'm not sure if that's why the diff is showing that all lines in the file are new. I only updated the reprojection options from line 81 to 105. Let me know if this poses a problem and we can find another way to submit the PR.

I also attempted to test this in one of the example notebooks but I received an error on the ipx.Query code block so I wasn't able to move forward. But these are the same updates I've applied to our basic access notebook on NSIDC's end so Im fairly confident this should fix things! Thanks for taking a look.

@JessicaS11
Copy link
Member

Hey @asteiker - It looks like somehow you've created a copy of the is2ref.py file in a different location (asteiker_icepyx/icepyx/icepyx/core/is2ref.py) than the original (icepyx/icepyx/core/is2ref.py), so git actually thinks it has a new file instead of modifying the original. I'm betting the changes aren't being picked up for running the notebook either. If you make the change (remove the "new" file and update the existing one) on your fork, when you commit the changes on GitHub it should also push them to this PR. I'll take a closer look at the example and review then.

@JessicaS11
Copy link
Member

@asteiker Any updates on this?

@asteiker
Copy link
Collaborator Author

Im closing this given the issues above. See new PR #153 with the same fix, with a clean fork off of the development branch.

@asteiker asteiker closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants