Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

<img /> received without src="" #5

Closed
meeshh opened this issue Apr 5, 2018 · 10 comments
Closed

<img /> received without src="" #5

meeshh opened this issue Apr 5, 2018 · 10 comments

Comments

@meeshh
Copy link

meeshh commented Apr 5, 2018

images are being received in the email without the src="" attribute. so no image is being loaded in the email.

@icetee
Copy link
Owner

icetee commented Apr 5, 2018

Unfortunately, it's hard coded to take image from the "img" folder.

But it encodes into base64 and handles CID-it.

Would you test it?

@meeshh
Copy link
Author

meeshh commented Apr 5, 2018

so there is no way to do it without a base64 encoding? i have all my images hosted somewhere online

@icetee
Copy link
Owner

icetee commented Apr 5, 2018

no, but I'll do it

icetee added a commit that referenced this issue Apr 5, 2018
@icetee
Copy link
Owner

icetee commented Apr 5, 2018

Can you test the last commit? Only change the ~/.atom/packages/palladium/lib/components/mailer.js file and reset the Atom window.

@meeshh
Copy link
Author

meeshh commented Apr 6, 2018

i updated the package in atom, restarted and tested it but i still get the same result.

@icetee
Copy link
Owner

icetee commented Apr 6, 2018

And add the new property to .mailconfig?

https://github.com/icetee/palladium/blame/c1fb29abab3f1932db49b6a19f363425c3fbf709/lib/settings/mailconfig.json

We are before publishing, we can only test it overwritten the file.

@meeshh
Copy link
Author

meeshh commented Apr 6, 2018

i added the new property and it didn't work.

@icetee
Copy link
Owner

icetee commented Apr 7, 2018

Can you give me more information, maybe example?

I try image src with external URL and set disableImageEncode: true and works.

I published the v1.2.0 release.

@meeshh
Copy link
Author

meeshh commented Apr 7, 2018

ok it works now. the update notification wasn't pushed to atom so i went to the packages tab and updated from there.

thank you.
you can close this issue

@icetee icetee closed this as completed Apr 7, 2018
@icetee
Copy link
Owner

icetee commented Apr 7, 2018

If you have any ideas for developing a package, open a new issue.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants