Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing converts line endings to CR LF #125

Closed
wolframroesler opened this issue Apr 19, 2019 · 4 comments
Closed

Editing converts line endings to CR LF #125

wolframroesler opened this issue Apr 19, 2019 · 4 comments

Comments

@wolframroesler
Copy link

Editing a .md file in the markdown editor automatically converts all line ending to Windows style (CR LF), even if the file is using Unix-style (LF only) line endings. Instead, the editor should analyze the file to find out which style it's using, create new lines with that style, and leave everything else unchanged.

To understand why the present behaviour is a problem, put a big Unix-style .md file into a git repo, put the repo into your Nextcloud, edit the file with the markdown editor, and then do "git diff".

@tessus
Copy link

tessus commented May 2, 2019

Yea, I have deactivated this app for now, because it ruins my markdown files.

I'm not sure if the repo owner reads any problem reports. My other issue hasn't received any reply yet either.

@wolframroesler
Copy link
Author

Too bad. Let's see when I get around to learning TypeScript so I can fix it myself, since this is a real showstopper.

@icewind1991
Copy link
Owner

Issues with the editor itself should be submitted to the files_texteditor repo, this app only deals with the markdown preview

@wolframroesler
Copy link
Author

Thanks for the info, and sorry for bothering you here.

Reported it here: nextcloud/files_texteditor#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants