Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#758 Mark submitted file errors #762

Merged
merged 57 commits into from May 16, 2022
Merged

#758 Mark submitted file errors #762

merged 57 commits into from May 16, 2022

Conversation

demariadaniel
Copy link
Contributor

@demariadaniel demariadaniel commented Apr 7, 2022 •
edited

Description of changes

Clinical Service / Platform API / Platform UI updates to query Program Clinical Entity Data & Errors

PR's:
icgc-argo/platform-ui#2284
icgc-argo/platform-api#548
#762

Issues:
#539: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/platform-api/539

#758: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/argo-clinical/758

#540: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/platform-api/540

Type of Change

  • Bug
  • Refactor
  • New Feature
  • Release Candidate

Checklist before requesting review:

  • Check branch (code change PRs go to develop not master)
  • Check copyrights for new files
  • Manual testing
  • Regression tests completed and passing (double check number of tests).
  • Spelling has been checked.
  • Updated swagger docs accordingly (check it's still valid)
  • Set validationDependency in meta tag for Argo Dictionary fields used in code

@demariadaniel demariadaniel changed the title WIP: 758/mark submitted file errors #758 Mark submitted file errors May 9, 2022
@demariadaniel demariadaniel requested a review from blabadi May 9, 2022 19:11
This was referenced May 9, 2022
Merged
Merged
blabadi
blabadi reviewed May 10, 2022
View reviewed changes
src/clinical/clinical-service.ts Outdated Show resolved Hide resolved
src/clinical/clinical-service.ts Outdated Show resolved Hide resolved
src/clinical/donor-repo.ts Outdated Show resolved Hide resolved
src/clinical/service-worker-thread/tasks.ts Outdated Show resolved Hide resolved
src/resources/swagger.yaml Show resolved Hide resolved
blabadi
blabadi reviewed May 10, 2022
View reviewed changes
src/clinical/clinical-api.ts Show resolved Hide resolved
src/clinical/clinical-api.ts Show resolved Hide resolved
@blabadi
Copy link
Contributor

blabadi commented May 10, 2022 •
edited

If you can at least add a couple happy path integration test for this new API, it would be great, it will help in avoiding regressions in the service

@demariadaniel
Copy link
Contributor Author

If you can at least add a couple happy path integration test for this new API, it would be great, it will help in avoiding regressions in the service

Will do! Once I resolve why 2 of our integration tests are failing....

@demariadaniel
Copy link
Contributor Author

If you can at least add a couple happy path integration test for this new API, it would be great, it will help in avoiding regressions in the service

Added basic identity integration tests @blabadi!

@demariadaniel demariadaniel merged commit da8dee2 into develop May 16, 2022
@blabadi blabadi mentioned this pull request Jun 7, 2022
Merged
1 task
blabadi added a commit that referenced this pull request Jun 7, 2022
@blabadi
Merge pull request #780 from icgc-argo/rc/1.64.0
ff3f50e 
Rc/1.64.0
Release Note:
- Adds a new clinical entity: Surgery 
- Adds surgery cross file validation rules. #773 
- implement Admin delete samples #776 
- add Submitted data table #774 
- Mark submitted file errors #762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabadi blabadi blabadi approved these changes

@joneubank joneubank Awaiting requested review from joneubank

@Buwujiu Buwujiu Awaiting requested review from Buwujiu

@samrichca samrichca Awaiting requested review from samrichca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@demariadaniel @blabadi @joneubank