Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐕 #539 Fetch All Clinical Data #2284

Merged
merged 37 commits into from May 18, 2022
Merged

🐕 #539 Fetch All Clinical Data #2284

merged 37 commits into from May 18, 2022

Conversation

demariadaniel
Copy link
Contributor

@demariadaniel demariadaniel commented Apr 13, 2022 •
edited

Description of changes

Clinical Service / Platform API / Platform UI updates to query Program Clinical Entity Data & Errors

PR's:
#2284
icgc-argo/platform-api#548
icgc-argo/argo-clinical#762

Issues:
#539: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/platform-api/539

#758: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/argo-clinical/758

#540: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/platform-api/540

Type of Change

  • Bug
  • Styling
  • New Feature

Checklist before requesting review:

  • Design (select one):
    • Matches design:
      • component sizes, spacing, and styles
      • font size, weight, colour
      • spelling has been double checked
    • No design provided, screenshot of changes included in PR
    • No changes to UI
  • UI Kit (select one):
    • New Components with storybook stories created
    • Modified Existing components and updates stories
    • No new UIKit components or changes
  • Feature is minimally responsive
  • Manual testing of UI feature
  • Add copyrights to new files
  • Connected ticket to PR

@demariadaniel
Basic Submitted Data Link
4ce3db3
@demariadaniel
Merge branch 'develop' of https://github.com/icgc-argo/platform-ui in…
9a725c4 
…to feat/539-fetch-all-clinical-data
@demariadaniel
Basic Clinical Data Query
889d47b
@demariadaniel
Clinical Submission Data Query
85696b1
@demariadaniel
Trim Down Query
cb66dd8
@demariadaniel
Working Clinical Data Query
1da48b8
@demariadaniel
Rename Query to Match Schema
38bf741
@demariadaniel
Working Clinical Data Query
e8bde21
@demariadaniel
Add Comment
88aa64d
@demariadaniel
Updated Query w/ Metadata + Completion
9e00ae8
@demariadaniel
Update Types w/ Completion + Schema Stats
d325a0b
@demariadaniel
Workinmg Alias for Errors
4cdc27e
@demariadaniel
Update Query
884b22b
@demariadaniel
Updated Query
b676ef9
@demariadaniel
Working Updated Query w/ Vars
f8e6ff3
@demariadaniel
Add withErrors
b16550f
@demariadaniel
Add EntityTypes to Query
e411de7
@demariadaniel
Demo Entity Types
449dfdb
@demariadaniel
Update to String Sort
eb9eb4a
@demariadaniel
Corrected EntityType Names
a258b61
@demariadaniel
Update Query with Working Sort + Pagination
684e876
@demariadaniel
Updated Query w/ working Clinical Errors
562e39b
@demariadaniel
Merge branch 'develop' of https://github.com/icgc-argo/platform-ui in…
78ebd42 
…to feat/539-fetch-all-clinical-data
@demariadaniel
Remove withErrors
bb60ded
@demariadaniel
Clean Up Query + Types
1feeab1
@demariadaniel
Rename 'clinicalErrors'
196c9ea
@demariadaniel
Add errorPolicy: all back
59205f5
@demariadaniel
Major Query Refactor
dd77584
@demariadaniel
Prevent undefined error
8fd8f4a
@demariadaniel
Working Filter for DonorID & SubmitterID
f811d82
This was referenced May 9, 2022
Merged
Merged
@demariadaniel demariadaniel changed the title WIP: Feat/539 fetch all clinical data Feat/539 fetch all clinical data May 10, 2022
@demariadaniel demariadaniel changed the title Feat/539 fetch all clinical data 🐕 #539 Fetch All Clinical Data May 17, 2022
joneubank
joneubank requested changes May 18, 2022
View reviewed changes
Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, just suggesting improvements for lighter data fetching and for code organization.

components/pages/submission-system/SideMenu.tsx Show resolved Hide resolved
components/pages/submission-system/SideMenu.tsx Show resolved Hide resolved
joneubank
joneubank approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@demariadaniel demariadaniel merged commit 6967b93 into develop May 18, 2022
@demariadaniel demariadaniel mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneubank joneubank joneubank approved these changes

@mistryrn mistryrn Awaiting requested review from mistryrn

@samrichca samrichca Awaiting requested review from samrichca

Assignees
No one assigned
Labels
1.109.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@demariadaniel @samrichca @joneubank