Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Spinner/Loading Indicator when waiting for download files to complete #2032

Closed
joneubank opened this issue Aug 27, 2021 · 4 comments
Assignees
Labels
1.105.0 new-feature Request is a new feature

Comments

@joneubank
Copy link
Member

joneubank commented Aug 27, 2021

When downloading TSV or manifest from the file repository, it can take a while for the file to be generated (10-30 seconds for ~25k files). While this is taking place on the server, there is no indication on the UI that any action is taking place. An indicator (little spinner over the button maybe) to indicate an action is occurring would ease the user's mind and prevent duplicate requests.

Detailed Description

  1. Go to File Repository
  2. Click Download -> TSV
  3. Wait
  4. File downloads

During the waiting in step 3 there is no indication that your download is being compiled, simply appears as though the request failed or wasn't submitted. Need an indicator

Possible Implementation

  • Change the icon to the spinner icon but keep the label of the button
  • if not part of ui kit, make it part of ui kit
@joneubank joneubank added the new-feature Request is a new feature label Aug 27, 2021
@rosibaj rosibaj added this to the [F x2] Donkey Kong Sprint 58 milestone Aug 30, 2021
@rosibaj rosibaj assigned mistryrn and unassigned rosibaj Aug 30, 2021
@rosibaj rosibaj removed this from the [FUTURE] Donkey Kong Sprint 58 milestone Sep 9, 2021
@kcullion kcullion added this to the Donkey Kong Sprint 63 milestone Nov 17, 2021
@demariadaniel
Copy link
Contributor

Create follow up ticket to add to UI kit after UI-kit is removed from platform
https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/icgc-argo/platform-ui/2095

@kcullion
Copy link

@demariadaniel I made a UI kit ticket for us to look at eventually making this behaviour standard in the platform, once the ui kit upgrades are done. Please add any more details that I may have missed icgc-argo/uikit#12

@kcullion
Copy link

@demariadaniel this looks great! will be a nice indication for the user. thanks!

@kcullion
Copy link

kcullion commented Feb 8, 2022

the loader is working in staging

@kcullion kcullion closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.105.0 new-feature Request is a new feature
Projects
None yet
Development

No branches or pull requests

6 participants