Remove bower, upgrade lodash v3 to v4

[cheapsteak]

No description provided.

[dcc-jenkins]

Deployed to https://dev.dcc.icgc.org/portals/299 for testing

[btiernay]

Conflicts.

[cheapsteak]

Merged with develop

[btiernay]

@SidSyrus / @cheapsteak we need to coordinate this merge with any outstanding UI branches. Otherwise bad things will happen.

[SidSyrus]

_.orderBy expects the sort order to be a string asc/desc while the old _.sortByOrder was expecting it to be a boolean true/false. You might have to change that as well.

@btiernay I think that was the reason why AS bar charts were not sorted.

[btiernay]

Good catch @SidSyrus. I think we should review this more thoroughly before testing. Is there a migration guide?

[btiernay]

Perhaps we should run this before and during this branch:

https://github.com/lodash/lodash-migrate

[cheapsteak]

_.orderBy expects the sort order to be a string asc/desc while the old _.sortByOrder was expecting it to be a boolean true/false

http://codepen.io/anon/pen/pRvOwj

```js
// Using lodash 4.15.0:
const sample = _.range(10).map(x => ({y: _.random(0, 100)}));
// [{"y":88},{"y":7},{"y":60},{"y":68},{"y":26},{"y":55},{"y":23},{"y":19},{"y":21},{"y":57}]
const sortedSample = _.orderBy(sample, 'y', true);
// [{"y":7},{"y":19},{"y":21},{"y":23},{"y":26},{"y":55},{"y":57},{"y":60},{"y":68},{"y":88}]
```

~~~Although a through review wouldn't hurt~~~

edit:oh shit nvm, reverse order doesn't work

[cheapsteak]

nvm realized reverse doesnt work

[cheapsteak]

Added lodash-migrate, quite a few warnings, will attend

[btiernay]

ok to test

[btiernay]

Please remove bower from setup instructions. Thanks

[btiernay]

@cheapsteak:

PhantomJS 2.1.1 (Linux 0.0.0) ERROR
 ReferenceError: Can't find variable: _
 at app/scripts/vendor.js:54

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0 ERROR (0.58 secs / 0 secs)

PhantomJS 2.1.1 (Linux 0.0.0) ERROR
 ReferenceError: Can't find variable: angular
 at app/scripts/index.js:35214

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0 ERROR (0.664 secs / 0 secs)

PhantomJS 2.1.1 (Linux 0.0.0) ERROR
 TypeError: Attempted to assign to readonly property.
 at node_modules/angular-mocks/angular-mocks.js:17

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0 ERROR (0.667 secs / 0 secs)

npm ERR! Test failed.  See above for more details.

[cheapsteak]

It's been removed

Were there other spots?

[btiernay]

Also, we have merged in develop so we should ensure that the merge didn't introduce old lodash usages:

525cab9

[btiernay]

@cheapsteak Any idea why the build is failing after the merge?

[btiernay]

Getting similar locally as well after cd dcc-portal-ui; rm -rf removing app/bower_components; mvn clean package:

  ReferenceError: Can't find variable: _
  at app/scripts/vendor.js:54

PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 0 of 0 ERROR (0.19 secs / 0 secs)

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  ReferenceError: Can't find variable: angular
  at app/scripts/index.js:35214

PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 0 of 0 ERROR (0.204 secs / 0 secs)

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  TypeError: Attempted to assign to readonly property.
  at node_modules/angular-mocks/angular-mocks.js:17

PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 0 of 0 ERROR (0.205 secs / 0 secs)```

[SidSyrus]

https://github.com/icgc-dcc/dcc-portal/commit/525cab953fc2abda92fc088356ddf779abf27bcd#diff-8c320a23e8338d7fac7be5b254660618R63

~~~Lodash V4 doesn't have `_.contains` method. I have the fix for it in my [branch](https://github.com/icgc-dcc/dcc-portal/blob/feature/DCCPRTL-99-debowerize-sid-branch/dcc-portal-ui/app/scripts/stackedbarchart/js/directives.js#L63). Should I request a PR to merge into this branch?~~~

Edit: NVM. The build still fails in my branch as well even with the mentioned change.

[btiernay]

_.includes

https://github.com/lodash/lodash/wiki/Changelog

[btiernay]

Actually, the build started failing before the merge at f1c4fa0:

https://dcc-jenkins.oicr.on.ca/job/dcc-portal-pr/2809/org.icgc.dcc$dcc-portal-ui/console

https://dcc-jenkins.oicr.on.ca/job/dcc-portal-pr/2808/org.icgc.dcc$dcc-portal-ui/console

  ReferenceError: Can't find variable: _
  at app/scripts/vendor.js:54

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0�[31m ERROR�[39m (0.813 secs / 0 secs)

�[31mPhantomJS 2.1.1 (Linux 0.0.0) ERROR�[39m
  ReferenceError: Can't find variable: angular
  at app/scripts/index.js:35214

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0�[31m ERROR�[39m (0.892 secs / 0 secs)

�[31mPhantomJS 2.1.1 (Linux 0.0.0) ERROR�[39m
  TypeError: Attempted to assign to readonly property.
  at node_modules/angular-mocks/angular-mocks.js:17

PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0�[31m ERROR�[39m (0.895 secs / 0 secs)

npm ERR! Test failed.  See above for more details.```

[btiernay]

Weird @codacy-bot, I wonder what makes you do the things you do when you do them.