Feature/remove zwj contenteditable false #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenbarker
changed the title
|
@ichord, this is ready for review. Please let me know if there are any changes that can be made to get this merged. Thanks! |
| if (range = this._getRange()) { | ||
| range.setEndAfter(this.query.el[0]); | ||
| range.collapse(false); | ||
| range.insertNode(suffixNode = this.app.document.createTextNode("\u200D" + suffix)); | ||
| range.insertNode(suffixNode = this.app.document.createTextNode + suffix); |
There was a problem hiding this comment.
@leb2dg Should it be this.app.document.createTextNode(suffix) ?
There was a problem hiding this comment.
Oops I see you fix it in the next commit.
There was a problem hiding this comment.
Yeah, I can clean up the commits and resolve the conflicts on this 👍
|
Closing in favor of #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be beneficial if it was an option to use
contenteditable="false"instead of the&zwj.Purpose
Fix unusual
contenteditablebehavior in WebKit browsers as described in #393.Changes
contenteditable="false"to inserted spanSide effects
Deleting the mention/emoji deletes the trigger (@, :, etc.).
Using
contenteditable="false"may cause unexpected behavior in old browsers or IE. I only tested this in Chrome, Firefox, and Safari. This article from 2014 describes a bug when usingcontenteditable="false"in Chrome and Safari but I couldn't reproduce it so it appears to be fixed.