Use contenteditable false instead of zwj #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compile changes fix insert node Compile after rebase
|
Good job, thanks @leb2dg |
escopecz
added a commit
to escopecz/mautic
that referenced
this pull request
May 3, 2017
sakalauskas
added a commit
to sakalauskas/At.js
that referenced
this pull request
Jun 2, 2017
fabmiz
added a commit
to fabmiz/At.js
that referenced
this pull request
Jun 22, 2017
cubeguerrero
added a commit
to zendesk/At.js
that referenced
this pull request
Jul 20, 2018
2 tasks
Spuds
added a commit
to Spuds/At.js
that referenced
this pull request
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #394
Purpose
Fix unusual
contenteditablebehavior in WebKit browsers as described in #393.Changes
contenteditable="false"to inserted spanSide effects
Deleting the mention/emoji deletes the trigger (@, :, etc.).
Using
contenteditable="false"may cause unexpected behavior in old browsers or IE. I only tested this in Chrome, Firefox, and Safari. This article from 2014 describes a bug when usingcontenteditable="false"in Chrome and Safari but I couldn't reproduce it so it appears to be fixed.