Update signals list

icicleio · Aug 9, 2015 · 710c5f3 · 710c5f3
1 parent d3fdbf8
commit 710c5f3
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 14 deletions.
diff --git a/src/Loop/Manager/AbstractSignalManager.php b/src/Loop/Manager/AbstractSignalManager.php
@@ -110,20 +110,49 @@ public function clear()
      */
     protected function getSignalList()
     {
-        return [
-            'SIGHUP'  => SIGHUP,
-            'SIGINT'  => SIGINT,
-            'SIGQUIT' => SIGQUIT,
-            'SIGILL'  => SIGILL,
-            'SIGABRT' => SIGABRT,
-            'SIGTERM' => SIGTERM,
-            'SIGCHLD' => SIGCHLD,
-            'SIGCONT' => SIGCONT,
-            'SIGTSTP' => SIGTSTP,
-            'SIGPIPE' => SIGPIPE,
-            'SIGUSR1' => SIGUSR1,
-            'SIGUSR2' => SIGUSR2,
+        $signals = [
+            SIGHUP,
+            SIGINT,
+            SIGQUIT,
+            SIGILL,
+            SIGABRT,
+            SIGTRAP,
+            SIGBUS,
+            SIGTERM,
+            SIGSEGV,
+            SIGFPE,
+            SIGALRM,
+            SIGVTALRM,
+            SIGPROF,
+            SIGIO,
+            SIGCONT,
+            SIGURG,
+            SIGPIPE,
+            SIGXCPU,
+            SIGXFSZ,
+            SIGTTIN,
+            SIGTTOU,
+            SIGUSR1,
+            SIGUSR2,
         ];
+
+        if (defined('SIGIOT')) {
+            $signals[] = SIGIOT;
+        }
+
+        if (defined('SIGSTKFLT')) {
+            $signals[] = SIGSTKFLT;
+        }
+
+        if (defined('SIGCLD')) {
+            $signals[] = SIGCLD;
+        }
+
+        if (defined('SIGCHLD')) {
+            $signals[] = SIGCHLD;
+        }
+
+        return $signals;
     }
 
     /**
@@ -144,12 +173,18 @@ protected function createSignalCallback()
                 case SIGHUP:
                 case SIGINT:
                 case SIGQUIT:
+                case SIGABRT:
+                case SIGTRAP:
+                case SIGXCPU:
                     if (!$handled) {
                         $this->loop->stop();
                     }
                     break;
 
                 case SIGTERM:
+                case SIGBUS:
+                case SIGSEGV:
+                case SIGFPE:
                     $this->loop->stop();
                     break;
             }

diff --git a/src/Loop/Manager/Libevent/SignalManager.php b/src/Loop/Manager/Libevent/SignalManager.php
@@ -23,7 +23,6 @@ class SignalManager extends AbstractSignalManager
     /**
      * @param \Icicle\Loop\LoopInterface $loop
      * @param \Icicle\Loop\Events\EventFactoryInterface $factory
-     * @param resource $base
      */
     public function __construct(LibeventLoop $loop, EventFactoryInterface $factory)
     {