2.0.2 - Performance

icidasset · Apr 25, 2019 · 6b48604 · 6b48604
1 parent 6eaa78c
commit 6b48604
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Changelog
 
 
+#### 2.0.2
+
+Another performance bump.
+
+
 #### 2.0.1
 
 Major performance improvements.

diff --git a/elm.json b/elm.json
@@ -3,7 +3,7 @@
     "name": "icidasset/elm-sha",
     "summary": "SHA cryptographic hash functions.",
     "license": "MIT",
-    "version": "2.0.1",
+    "version": "2.0.2",
     "exposed-modules": [
         "SHA"
     ],

diff --git a/src/SHA/Internal/Common.elm b/src/SHA/Internal/Common.elm
@@ -48,24 +48,18 @@ combine : Int -> Bits -> Bits -> Bits
 combine sizeInBits x y =
     let
         sum =
-            Binary.dropLeadingZeros (Binary.add x y)
+            Binary.add x y
 
         width =
             Binary.width sum
     in
     if width > sizeInBits then
-        let
-            excess =
-                width - sizeInBits
-        in
         -- Is the sum larger than the modulo constant (ie. 2 ^ sizeInBits)?
         sum
             |> Binary.toBooleans
-            |> List.drop excess
+            |> List.drop (width - sizeInBits)
             |> Binary.fromBooleans
-            |> Binary.dropLeadingZeros
-            |> Binary.ensureSize sizeInBits
 
     else
         -- If not, carry on.
-        Binary.ensureSize sizeInBits sum
+        sum