Fix nullptr dereferences #6104
Merged
Fix nullptr dereferences #6104
+103
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why commit c508d74 is in there :/ |
|
Wrong rebase base, I'd suggest to start with a fresh master and cherry-pick on-top into a new branch. |
dnsmichi
reviewed
Feb 20, 2018
lib/base/object.hpp
Outdated
| @@ -57,6 +57,10 @@ extern Value Empty; | |||
| DECLARE_PTR_TYPEDEFS(klass); \ | |||
| IMPL_TYPE_LOOKUP(); | |||
|
|
|||
| #define RequireNotNull(ptr) RequireNotNullInternal(ptr, #ptr) | |||
There was a problem hiding this comment.
Macros should be capitalised throughout, so REQUIRE_NOT_NULL would be correct, wouldn't it?
|
When merging back into the master the files relevant to the commit are not touched. Sometimes git works in mysterious ways 🙄 |
This is used to fix a number of possible nullptr dereferences
Crunsher
force-pushed
the
fix/nullptr-deref
branch
from
7b1d9ed
to
a71ab1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a number of nullptr dereferences within icinga 2.
Refs CVE-2018-6534