Add support to include an excel file (.xls or .xlsx) directly #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know the reason of failure, help needed. |
|
Sorry, I should've review this much earlier. Eventually I'll add support to this, but the current priority would be #51 which requires major rewriting. Also I'd classify pandas as an optional dependency. I uses it almost every day but it is not something I want to impose on the others. Lastly, I'd not commit binaries to this repo and I know how to include a test there without doing so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the feature of include a
.csvfile. But for people heavily depends on excel files, it would be nice to be able to include an MS Excel file. Here's this.To simplify reading, I used
pandas. I think it's not a good idea to makepandasas a must requirement. So for people who don't work with excel, the filter works just as before, though the test may not pass without pandas installed (maybe skip excel test if pandas not exist?).