Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we are catching/logging all exceptions #15

Closed
ben-jones opened this issue Sep 4, 2014 · 2 comments
Closed

Ensure that we are catching/logging all exceptions #15

ben-jones opened this issue Sep 4, 2014 · 2 comments

Comments

@ben-jones
Copy link
Contributor

Before we deploy to our initial set of clients, we need to make sure that we are logging all of the exceptions. This will allow us to understand what went wrong when/if our program crashes

@gsathya
Copy link
Contributor

gsathya commented Sep 12, 2014

(centinel)➜  centinel git:(master) ack "Exception" -A 2 centinel/
centinel/backend.py
94:        except Exception as e:
95-            logging.error("Unable to register: %s" % str(e))
96-            raise e
--
104:    except Exception, e:
105-        logging.error("Unable to create user: %s" % str(e))
106-        return
--
114:        except Exception, e:
115-            logging.error("Unable to send result file: %s" % str(e))
116-
--
129:    except Exception, e:
130-        logging.error("Unable to download experiment files %s", str(e))
131-

centinel/client.py
78:            except Exception, e:
79-                logging.error("Error in %s: %s" % (name, str(e)))
80-

centinel/experiments/tcp_connect.py
30:        except Exception as err:
31-            result["failure"] = str(err)
32-

centinel/experiments/turkey.py
44:        except Exception as err:
45-            result["blocked"] = str(err)
46-

centinel/primitives/http.py
34:    except Exception as err:
35-        response["failure"] = str(err)
36-

looks like we are? @ben-jones should i close this?

@ben-jones
Copy link
Contributor Author

@gsathya, sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants