This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Allow user to override #output_strategy and choose array, live, or console_log #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsole_log This adds the ability to use neither console.log or live delivery, but elect to just collect KM events in _kmq. This change is backwards compatible with existing code that overrides the #use_fake_kissmetrics_api? method and preserves its behavior.
iconara
added a commit
that referenced
this pull request
Jun 30, 2011
Allow user to override #output_strategy and choose array, live, or console_log
|
Looks good, I've merged and pushed up v0.1.8 to RubyGems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For the app I'm working on, I'd like to choose for events to be simply stored in the _kmq array, in addition to the choices of console.log and live delivery.
In this patch, I allow the user to override #output_strategy and choose :array, :live, or :console_log. This change is backwards compatible with existing code that overrides the #use_fake_kissmetrics_api? method, and preserves its behavior.
Let me know your thoughts. Thanks!
-Jason