Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max versions for base and base-compat #172

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

josephcsible
Copy link
Contributor

The MonadFail proposal is forced in base 4.13 and base-compat 0.11, and we don't support it yet.

This fixes errors when trying to install with cabal (because it pulls base-compat 0.11 otherwise) that look something like this:

Text/RE/ZeInternals/SearchReplace.hs:47:55: error:
    • Could not deduce (MonadFail m) arising from a use of ‘fail’
      from the context: Monad m
...
   |
47 | compileSearchReplace_ pack compile_re sr_tpl = either fail return $ do
   |                                                       ^^^^

The MonadFail proposal is forced in base 4.13 and
base-compat 0.11, and we don't support it yet.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.079% when pulling 0fd361e on josephcsible:nomonadfail into ff3e807 on iconnect:master.

@cdornan cdornan merged commit 0fd361e into iconnect:master Jan 27, 2020
@josephcsible josephcsible deleted the nomonadfail branch January 27, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants